Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export name and version on module #129

Merged
merged 2 commits into from
Nov 7, 2017
Merged

feat: export name and version on module #129

merged 2 commits into from
Nov 7, 2017

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Nov 7, 2017 •
edited

Description of the Changes

add export of name and version of library.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe self-assigned this Nov 7, 2017
@OrenMe OrenMe requested review from dvh91 and dan-ziv November 7, 2017 13:56
dan-ziv
dan-ziv previously approved these changes Nov 7, 2017
View reviewed changes
@OrenMe OrenMe merged commit 8f88c26 into master Nov 7, 2017
@OrenMe OrenMe deleted the exportedVars branch November 7, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

@dvh91 dvh91 Awaiting requested review from dvh91

Assignees

@OrenMe OrenMe

Labels
Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OrenMe @dan-ziv