Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose logger API #132

Merged
merged 8 commits into from
Nov 14, 2017
Merged

feat: expose logger API #132

merged 8 commits into from
Nov 14, 2017

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Nov 11, 2017

Description of the Changes

set to ERROR level by default
expose API to set and get log level and get log level enums
expose convenience method to set logger level via global window param window.PLAYKIT_LOG_LEVEL
update to JS-Logger V1.4

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

set to ERROR level by default
expose API to set and get log level and get log level enums
expose convenience method to set logger level via global window param window.PLAYKIT_LOG_LEVEL
update to JS-Logger V1.4
@OrenMe OrenMe self-assigned this Nov 11, 2017
@dan-ziv dan-ziv merged commit 252e9d2 into master Nov 14, 2017
@dan-ziv dan-ziv deleted the loggerRefactor branch November 14, 2017 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants