Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7531): cvaa 'Apply' button shown only on hover with wrong line height #138

Merged
merged 1 commit into from
Nov 26, 2017
Merged

fix(FEC-7531): cvaa 'Apply' button shown only on hover with wrong line height #138

merged 1 commit into from
Nov 26, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Nov 26, 2017 •
edited

Description of the Changes

Fix cvaa 'Apply' button css definitions.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Nov 26, 2017
@dan-ziv dan-ziv requested review from OrenMe and dvh91 November 26, 2017 09:43
@dan-ziv dan-ziv changed the title fix: cvaa 'Apply' button shown only on hover with wrong line height fix(FEC-7531): cvaa 'Apply' button shown only on hover with wrong line height Nov 26, 2017
@dan-ziv dan-ziv merged commit 5599cc8 into master Nov 26, 2017
@dan-ziv dan-ziv deleted the fix-cvaa-apply-button branch November 26, 2017 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

@dvh91 dvh91 Awaiting requested review from dvh91

Assignees

@dan-ziv dan-ziv

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @yairans