Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable keyboard seek on ad break #143

Merged
merged 2 commits into from
Nov 28, 2017
Merged

fix: disable keyboard seek on ad break #143

merged 2 commits into from
Nov 28, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Nov 27, 2017 •
edited

Description of the Changes

Seek is not allowed while ad is playing, so check if props.adBreak set to true and if this the case don't run logic.
Also general fix is added where we are passing to the seekbar component the correct playerContainer via the ads preset.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Nov 27, 2017
@dan-ziv dan-ziv requested a review from OrenMe November 27, 2017 14:52
@dan-ziv dan-ziv merged commit 899e69c into master Nov 28, 2017
@dan-ziv dan-ziv deleted the disable-keyboard-seek-on-ad branch November 28, 2017 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@dan-ziv dan-ziv

Labels
Priority: Medium Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @OrenMe