Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keyboard shortcuts ui gestures #149

Merged
merged 12 commits into from
Jan 10, 2018
Merged

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Nov 29, 2017

Description of the Changes

Added keyboard shortcuts gestures to UI.

  • Refactor the overlay-play component and rename it to overlay-action which can display overlay action gesture of any kind of icon.
  • Added store for the overlay-action component. Using this store the keyboard component (or any other component) can call updateOverlayActionIcon(...) and supply an icon/s. The overlay-action component will know to display the correct icon based on the updated iconType prop.
  • Fix the overlay animation to look like in Hillel's demo.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Nov 29, 2017
@dan-ziv dan-ziv requested review from OrenMe and dvh91 November 29, 2017 13:09
@dan-ziv
Copy link
Contributor Author

dan-ziv commented Dec 10, 2017

@OrenMe please review
10x

@dan-ziv dan-ziv merged commit 9e922db into master Jan 10, 2018
@dan-ziv dan-ziv deleted the keyboard-shortcuts-ui-gestures branch January 10, 2018 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant