fix(FEC-7368): no spinner between ads and spinner doesn't stop on autoplay on native adapter #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
previously approved these changes
Dec 21, 2017
OrenMe
reviewed
Dec 21, 2017
| @@ -89,6 +90,9 @@ class Loading extends BaseComponent { | |||
| } | |||
|
|
|||
| this.player.addEventListener(this.player.Event.PLAYER_STATE_CHANGED, e => { | |||
| if (!this.state.afterPlayingEvent) { | |||
There was a problem hiding this comment.
I think we are starting to have duplicate logic here, and maybe it's better to consider moving to playback events based state only and not state change event.
You already see that we both register to playing event a few line below and do the same action there and also in here in state change to playing.
OrenMe
approved these changes
Jan 21, 2018
dan-ziv
approved these changes
Jan 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Added a state (afterPlayingEvent) the checks if the entry started playing, it listens to the PLAYING event.
PLAYER_STATE_CHANGED events are ignored until 'afterPlayingEvent' state is set to true.
@dan-ziv, i checked with/without autoplay and with/without ads. It seems to work, but I remember you have some notes about this fix.
CheckLists