Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-7807): no unmute icon on ads on mobile #165

Merged
merged 3 commits into from
Jan 29, 2018
Merged

fix(FEC-7807): no unmute icon on ads on mobile #165

merged 3 commits into from
Jan 29, 2018

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Jan 16, 2018

Description of the Changes

Changed the return element from 'undefined' to return a player wrapper with the unmute component

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@@ -78,7 +85,7 @@ function getAdsUiCustomization(): Object {
* @param {any} props - component props
* @returns {boolean} - Whether the default ads ui should be shown or not.
*/
function useDefaultAdsUi(props: any): boolean {
function useDefaultAdsUi(props: any): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix indent

@dan-ziv
Copy link
Contributor

dan-ziv commented Jan 18, 2018

@odedhutzler
Did u check with iOS native player that it's works fine?

@dan-ziv dan-ziv merged commit f83da1f into master Jan 29, 2018
@dan-ziv dan-ziv deleted the FEC-7807 branch January 29, 2018 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants