Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-7907): No play button when preload and ima plugin #173

Merged
merged 3 commits into from
Feb 19, 2018
Merged

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Feb 14, 2018

Description of the Changes

show pre playback play button as soon as possible and load spinner once clicked
this change is possible since kaltura/playkit-js#193

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Feb 14, 2018
* load spinner on pre-play click
@dan-ziv dan-ziv requested a review from OrenMe February 14, 2018 13:40
@dan-ziv dan-ziv merged commit 20e98f6 into master Feb 19, 2018
@dan-ziv dan-ziv deleted the FEC-7907 branch February 19, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants