Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7910): When using the custom captions menu, the video is totally blocked and not blurred #175

Merged
merged 1 commit into from
Feb 18, 2018
Merged

fix(FEC-7910): When using the custom captions menu, the video is totally blocked and not blurred #175

merged 1 commit into from
Feb 18, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Feb 18, 2018 •
edited

Description of the Changes

Override overlay class just if error UI is displayed.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Feb 18, 2018
@dan-ziv dan-ziv merged commit d178ff0 into master Feb 18, 2018
@dan-ziv dan-ziv deleted the FEC-7910 branch February 18, 2018 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@odedhutzler odedhutzler odedhutzler approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@dan-ziv dan-ziv

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dan-ziv @OrenMe @odedhutzler