Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dropdown position calculation #181

Merged
merged 3 commits into from
Feb 21, 2018
Merged

fix: dropdown position calculation #181

merged 3 commits into from
Feb 21, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Feb 20, 2018

Description of the Changes

Fix calculation of dropdown positioning to relative to player container.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Feb 20, 2018
@dan-ziv dan-ziv requested a review from OrenMe February 20, 2018 16:23
@OrenMe
Copy link
Contributor

OrenMe commented Feb 21, 2018

Looks good 👍

@dan-ziv dan-ziv merged commit 240e69a into master Feb 21, 2018
@dan-ziv dan-ziv deleted the fix-dropdown-position-calculation branch February 21, 2018 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@dan-ziv dan-ziv

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @OrenMe