Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7956): When autoplay fails, loading spinner stays in the background #183

Merged
merged 1 commit into from
Feb 26, 2018
Merged

fix(FEC-7956): When autoplay fails, loading spinner stays in the background #183

merged 1 commit into from
Feb 26, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Feb 26, 2018 •
edited by OrenMe

Description of the Changes

Hide loading spinner when autoplay failed event is triggered.
Also, get rid of the mobileAutoplay flags since its redundant and doesn't exists in the player.

caused by #156

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Feb 26, 2018
@dan-ziv dan-ziv merged commit da5ac5f into master Feb 26, 2018
@dan-ziv dan-ziv deleted the FEC-7956 branch February 26, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans yairans approved these changes

Assignees

@dan-ziv dan-ziv

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dan-ziv @OrenMe @yairans