Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7964): touch while playing on mobiles always pause/resume the video #193

Merged
merged 2 commits into from
Mar 7, 2018
Merged

fix(FEC-7964): touch while playing on mobiles always pause/resume the video #193

merged 2 commits into from
Mar 7, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Mar 7, 2018 •
edited

Description of the Changes

Fix regression issue when bottom bar doesn't appears on mobiles when video starts to play.
Change the hover state to start on first playing instead of first play.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Mar 7, 2018
@dan-ziv dan-ziv merged commit 3dacd30 into master Mar 7, 2018
@dan-ziv dan-ziv deleted the FEC-7964_cont branch March 7, 2018 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaykinnrot itaykinnrot itaykinnrot approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@dan-ziv dan-ziv

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @itaykinnrot