Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7988): [watermark] - when using a custom image it partially h… #194

Merged
merged 1 commit into from
Mar 7, 2018
Merged

fix(FEC-7988): [watermark] - when using a custom image it partially h… #194

merged 1 commit into from
Mar 7, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Mar 7, 2018 •
edited

…ides the play/replay icons

Description of the Changes

  • move the z-index setting from pre-playback-overlay to pre-playback-button
  • decrease the watermark z-index to not overlap the menus

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Mar 7, 2018
@yairans yairans changed the title fix(FEC-7988): [Watermark] - When using a custom image it partially h… fix(FEC-7988): [watermark] - when using a custom image it partially h… Mar 7, 2018
@yairans yairans merged commit 0ebf9aa into master Mar 7, 2018
@yairans yairans deleted the FEC-7988 branch March 7, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

@itaykinnrot itaykinnrot Awaiting requested review from itaykinnrot

Assignees

@yairans yairans

Labels
Priority: High
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @dan-ziv