Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-7964): after first play the control bar is hidden on touch devices #198

Merged
merged 1 commit into from
Mar 11, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Mar 9, 2018

Description of the Changes

Previous logic shows the hover state on first time the player started to play.
But when we played entry with preload=auto it was still too early since props.prePlayback was still has true value in _updatePlayerHoverState what caused the method to terminate.
Change the implementation to when component did update with changes props from prePlayback to !prePlayback => show the hover state for the first time.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Mar 9, 2018
@dan-ziv dan-ziv requested review from OrenMe and yairans March 9, 2018 10:19
@dan-ziv dan-ziv merged commit 527289e into master Mar 11, 2018
@dan-ziv dan-ziv deleted the FEC-7964 branch March 11, 2018 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants