Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-8079): hide UI on player RESET event #207

Merged
merged 3 commits into from
Mar 27, 2018
Merged

fix(FEC-8079): hide UI on player RESET event #207

merged 3 commits into from
Mar 27, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Mar 26, 2018

Description of the Changes

Add isStopped state in the engine reducer and do not render the PlayerGUI component when player is stopped! (we still want to render the other components, like VideoPlayer for example, since the video element placed there)

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Mar 26, 2018
@odedhutzler
Copy link
Contributor

so from what i understand here, we will stay with the old ui (and spinner) until the stop flag is turned false (meaning the player reseted?)

OrenMe
OrenMe previously approved these changes Mar 27, 2018
@dan-ziv dan-ziv merged commit f6f51be into master Mar 27, 2018
@dan-ziv dan-ziv deleted the FEC-8079 branch March 27, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants