Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-8084): add loading spinner while preforming change media #209

Merged
merged 3 commits into from
Apr 9, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Mar 29, 2018

Description of the Changes

  1. Build a reset preset which will allow us to change and extend the player UI when stopped - for now only the loading component appear there.
  2. Fix logic in loading & pre playback components.
  3. create util methods in component-config.js to allow components reducers to handle config actions.
  4. Add listeners in loading reducer to config change actions.

TODOS:
Change all components which supports external config to handle it like the loading reducer.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Mar 29, 2018
@dan-ziv dan-ziv requested a review from OrenMe March 29, 2018 08:34
@dan-ziv dan-ziv merged commit 2c702cd into master Apr 9, 2018
@dan-ziv dan-ziv deleted the FEC-8084 branch April 9, 2018 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant