fix(FEC-8099): remove the seek bar while ad #210
Conversation
| @@ -51,12 +51,6 @@ export default function adsUI(props: any): ?React$Element<any> { | |||
| {adsUiCustomization.skipButton ? <AdSkip player={props.player}/> : undefined} | |||
| </div> | |||
| <BottomBar> | |||
| <SeekBarAdsContainer | |||
There was a problem hiding this comment.
Or even better,
Why not to check in the seekbar component if the uiElements appear in IMA config and just in that case to remove the seekbar?
There was a problem hiding this comment.
IMO you want the behaviour to be consistent and not dependent on other 3rd party factors.
Also, the seek bar and the time label act as the same here as both indicate time, and seek bar doesn't have it's usual seek behaviour, so in terms of functionality they do the same - and in our case the seekbar also takes needed space - so better to just remove it.
| @@ -51,12 +51,6 @@ export default function adsUI(props: any): ?React$Element<any> { | |||
| {adsUiCustomization.skipButton ? <AdSkip player={props.player}/> : undefined} | |||
| </div> | |||
| <BottomBar> | |||
| <SeekBarAdsContainer | |||
There was a problem hiding this comment.
IMO you want the behaviour to be consistent and not dependent on other 3rd party factors.
Also, the seek bar and the time label act as the same here as both indicate time, and seek bar doesn't have it's usual seek behaviour, so in terms of functionality they do the same - and in our case the seekbar also takes needed space - so better to just remove it.
seekbarAdsContainer component is unused from kaltura/playkit-js-ui#210. deleted.
Description of the Changes
the seek bar is unnecessary while ad, also it takes needed space - removed while ad
CheckLists