Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8099): delete seekbarAdsContainer component #213

Merged
merged 4 commits into from
Apr 8, 2018
Merged

fix(FEC-8099): delete seekbarAdsContainer component #213

merged 4 commits into from
Apr 8, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Apr 8, 2018 •
edited

Description of the Changes

seekbarAdsContainer component is unused from #210. deleted.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans changed the title Fec 8099 fix(FEC-8099): delete seekbarAdsContainer component Apr 8, 2018
@yairans yairans requested a review from OrenMe April 8, 2018 14:33
@yairans yairans self-assigned this Apr 8, 2018
@dan-ziv dan-ziv self-requested a review April 8, 2018 15:24
@yairans yairans merged commit 24849b2 into master Apr 8, 2018
@yairans yairans deleted the FEC-8099 branch April 8, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

Assignees

@yairans yairans

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @dan-ziv