feat(FEC-8102): toggle fullscreen on double click #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
previously approved these changes
Apr 9, 2018
|
|
||
| if (currentTime - this._firstClickTime < PLAY_PAUSE_BUFFER_TIME ) { | ||
| this.clickTimeout && clearTimeout(this.clickTimeout); | ||
| this._secondClickTime = currentTime; |
There was a problem hiding this comment.
remove all _secondClickTime uses.
| let currentTime = Date.now(); | ||
|
|
||
| if (currentTime - this._firstClickTime < PLAY_PAUSE_BUFFER_TIME ) { | ||
| this.clickTimeout && clearTimeout(this.clickTimeout); |
There was a problem hiding this comment.
Move this to a function:
const cancelClickTimeout = () => {
if (this.clickTimeout){
clearTimeout(this.clickTimeout);
this.clickTimeout = null;
}
}and use in both if conditions.
dan-ziv
previously requested changes
Apr 9, 2018
| if (!this.player.isFullscreen()) { | ||
| this.logger.debug("Enter fullscreen"); | ||
| this.player.enterFullscreen(); | ||
|
|
| @@ -85,7 +118,30 @@ class OverlayAction extends BaseComponent { | |||
| if (this.props.isMobile) { | |||
| return; | |||
| } | |||
| this.togglePlayPause(); | |||
|
|
|||
| let currentTime = Date.now(); | |||
| } | ||
|
|
||
| this._firstClickTime = currentTime; | ||
|
|
There was a problem hiding this comment.
remove empty and redundant lines...
move cancelTimeout to a function removing _secondClickTime fixing flow
dan-ziv
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
added logic to support differentiate double click from single click.
CheckLists