-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FEC-6940): dropdown icon in ie11 fix #22
Conversation
src/styles/_dropdown.scss
Outdated
@@ -25,7 +25,7 @@ | |||
padding-left: 20px; | |||
|
|||
.icon { | |||
width: 16px; | |||
width: 16px; height: 16px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvh91 please fix - one rule at a line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OrenMe - I usually use width and height in the same line as it makes sense.
same for 'top' 'bottom' 'left' and 'right'.
it's more readable IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair, but still, let's make it 1 line per item, as most, if not all AFAIK, beautifiers will format it like that
src/styles/_dropdown.scss
Outdated
@@ -25,7 +25,7 @@ | |||
padding-left: 20px; | |||
|
|||
.icon { | |||
width: 16px; | |||
width: 16px; height: 16px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair, but still, let's make it 1 line per item, as most, if not all AFAIK, beautifiers will format it like that
No description provided.