Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UI options flow type #221

Merged
merged 2 commits into from
Apr 16, 2018
Merged

fix: UI options flow type #221

merged 2 commits into from
Apr 16, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Apr 16, 2018 •
edited

Description of the Changes

Causing the kaltura player build to fails.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Apr 16, 2018
@dan-ziv dan-ziv requested a review from OrenMe April 16, 2018 06:28
@yairans yairans self-requested a review April 16, 2018 06:50
@dan-ziv dan-ziv merged commit 961a081 into master Apr 16, 2018
@dan-ziv dan-ziv deleted the fix-ui-options-flow-type branch April 16, 2018 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @yairans