Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7976): when bootstrap reset is on the page the player menus and CVAA is not working right #222

Merged
merged 4 commits into from
May 6, 2018
Merged

fix(FEC-7976): when bootstrap reset is on the page the player menus and CVAA is not working right #222

merged 4 commits into from
May 6, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Apr 17, 2018 •
edited

Description of the Changes

Be more specific than bootstrap where's possible

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv requested review from OrenMe and yairans April 17, 2018 13:51
@dan-ziv dan-ziv changed the title fix(FEC-7976): when bootstrap reset is on the page the V3 player menus and CVAA is not working right fix(FEC-7976): when bootstrap reset is on the page the player menus and CVAA is not working right Apr 17, 2018
OrenMe
OrenMe reviewed Apr 17, 2018
View reviewed changes
Copy link
Contributor

@OrenMe OrenMe left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about adding player prefix to styles/_inputs.scss?

@dan-ziv
Copy link
Contributor Author

dan-ziv commented Apr 17, 2018

@OrenMe done

@dan-ziv dan-ziv merged commit 137411c into master May 6, 2018
@dan-ziv dan-ziv deleted the FEC-7976 branch May 6, 2018 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @OrenMe