Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8134): replay fails on iOS for playback with ads #224

Merged
merged 1 commit into from
Apr 22, 2018
Merged

fix(FEC-8134): replay fails on iOS for playback with ads #224

merged 1 commit into from
Apr 22, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Apr 22, 2018 •
edited

Description of the Changes

since z-index exists on the ads container, click on the pre-playback isn't triggered. We can safely remove the z-indexes since the layers are now organised correctly.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Apr 22, 2018
@dan-ziv dan-ziv requested review from OrenMe and yairans April 22, 2018 08:21
@dan-ziv dan-ziv merged commit 30e6c89 into master Apr 22, 2018
@dan-ziv dan-ziv deleted the FEC-8134 branch April 22, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @OrenMe