Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-8136): quality tracks are filtered by height instead of by label #225

Merged
merged 3 commits into from
Apr 22, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Apr 22, 2018

Description of the Changes

Filtering the quality tracks by label
required for support displaying quality tracks with same height by different label
e.g:

track1: {
    height: 360,
    width: 640,
    bandwidth: 700000,
    label: 'low'
},
track2: {
    height: 360,
    width: 640,
    bandwidth: 800000,
    label: 'high'
}

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change the comment above, it says

in the sorted array has the same resolution as the new

while we now compare the label

@yairans yairans changed the title fix(FEC-8136): quality tracks filtered by height instead of by label fix(FEC-8136): quality tracks are filtered by height instead of by label Apr 22, 2018
@yairans yairans merged commit afe561f into master Apr 22, 2018
@yairans yairans deleted the quality-filter branch April 22, 2018 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants