Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8058): mouse cursor not released after seek action in firefox #226

Merged
merged 3 commits into from
May 6, 2018
Merged

fix(FEC-8058): mouse cursor not released after seek action in firefox #226

merged 3 commits into from
May 6, 2018

Conversation

odedhutzler
Copy link
Contributor

Description of the Changes

added e.preventDefault() to the mouse down event. which solves this - according to:
https://stackoverflow.com/questions/9506041/javascript-events-mouseup-not-firing-after-mousemove

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Apr 22, 2018
OrenMe
OrenMe previously approved these changes Apr 22, 2018
View reviewed changes
@dan-ziv dan-ziv merged commit 352fdee into master May 6, 2018
@dan-ziv dan-ziv deleted the FEC-8058 branch May 6, 2018 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

@OrenMe OrenMe OrenMe left review comments

@yairans yairans Awaiting requested review from yairans

Assignees

@odedhutzler odedhutzler

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@odedhutzler @OrenMe @dan-ziv