Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-8141): prevent scroll when seeking on mobile #227

Merged
merged 4 commits into from
May 6, 2018
Merged

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Apr 23, 2018

prevent the default behaviour when dragging so the window won't scroll left or right when dragging the seekbar
enlarging the touch area of the seekbar, for easier scrolling

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

prevent the default behaviour when dragging so the window won't scroll left or right when dragging the seekbar
enlarging the touch area of the seekbar, for easier scrolling
@odedhutzler odedhutzler self-assigned this Apr 23, 2018
OrenMe
OrenMe previously approved these changes Apr 23, 2018
@dan-ziv dan-ziv merged commit 41ba7f6 into master May 6, 2018
@dan-ziv dan-ziv deleted the FEC-8141 branch May 6, 2018 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants