Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8154): notifyClick error is throwing when seeking live with DVR #232

Merged
merged 2 commits into from
May 6, 2018
Merged

fix(FEC-8154): notifyClick error is throwing when seeking live with DVR #232

merged 2 commits into from
May 6, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Apr 25, 2018 •
edited

Description of the Changes

Add the notifyClick handler also to the seekbar-live-playback-container.js

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Apr 25, 2018
@dan-ziv dan-ziv requested review from OrenMe and yairans April 25, 2018 08:24
@dan-ziv dan-ziv changed the title fix(FEC-XXXX): notifyClick error is throwing when seeking live with DVR fix(FEC-8154): notifyClick error is throwing when seeking live with DVR Apr 25, 2018
@dan-ziv dan-ziv merged commit 0ed9cd7 into master May 6, 2018
@dan-ziv dan-ziv deleted the notify-click-live-with-dvr-error branch May 6, 2018 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @OrenMe