Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8180): when video starts fallback muted and user select to change media the unmute icon is not displayed although video still muted #238

Merged
merged 2 commits into from
May 24, 2018
Merged

fix(FEC-8180): when video starts fallback muted and user select to change media the unmute icon is not displayed although video still muted #238

merged 2 commits into from
May 24, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented May 24, 2018 •
edited

Description of the Changes

Save a single state of fallback to muted and use it in shell and unmute-indication components.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this May 24, 2018
@dan-ziv dan-ziv requested review from OrenMe and yairans May 24, 2018 09:18
@dan-ziv dan-ziv changed the title fix(FEC-8180):when video starts fallback muted and user select to change media the Unmute icon is not displayed although video still muted fix(FEC-8180): when video starts fallback muted and user select to change media the Unmute icon is not displayed although video still muted May 24, 2018
OrenMe
OrenMe previously approved these changes May 24, 2018
View reviewed changes
@dan-ziv dan-ziv changed the title fix(FEC-8180): when video starts fallback muted and user select to change media the Unmute icon is not displayed although video still muted fix(FEC-8180): when video starts fallback muted and user select to change media the unmute icon is not displayed although video still muted May 24, 2018
@dan-ziv dan-ziv merged commit c3bb7c0 into master May 24, 2018
@dan-ziv dan-ziv deleted the FEC-8180 branch May 24, 2018 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe left review comments

@yairans yairans Awaiting requested review from yairans

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @OrenMe