Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8046): 360 support #245

Merged
merged 12 commits into from
Jun 20, 2018
Merged

feat(FEC-8046): 360 support #245

merged 12 commits into from
Jun 20, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jun 20, 2018 •
edited

Description of the Changes

  • overlay-action:
    • pass isVr prop
    • handle click by pointerdown/pointerup events instead of bu click to distinguish between
      click and dragging.
  • change the shell touch handler as a result the overlay-action changes
  • add stereo control
  • trigger window.resize on in-browser fullscreen actions

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans merged commit 079f82b into master Jun 20, 2018
@yairans yairans deleted the FEC-8046 branch June 20, 2018 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yairans