Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8338): [360][Android] Play/Pause sometimes is not working #246

Merged
merged 1 commit into from
Jun 21, 2018
Merged

fix(FEC-8338): [360][Android] Play/Pause sometimes is not working #246

merged 1 commit into from
Jun 21, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jun 21, 2018 •
edited

Description of the Changes

add a threshold of 5 to consider minor movement as click and not as dragging

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Jun 21, 2018
@yairans yairans changed the title fix: play/pause click on 360 content is too sensitive fix(FEC-8338): [360][Android] Play/Pause sometimes is not working Jun 21, 2018
@yairans yairans merged commit 3346024 into master Jun 21, 2018
@yairans yairans deleted the dragging-threshold branch June 21, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@itaykinnrot itaykinnrot Awaiting requested review from itaykinnrot

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe