Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8368): isVr method throws exception on change media #252

Merged
merged 1 commit into from
Jul 2, 2018
Merged

fix(FEC-8368): isVr method throws exception on change media #252

merged 1 commit into from
Jul 2, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jul 2, 2018 •
edited

Description of the Changes

get isVr from props.state.engine.isVr instead of from player API

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Jul 2, 2018
@yairans yairans requested review from OrenMe and dan-ziv July 2, 2018 08:34
@yairans yairans mentioned this pull request Jul 2, 2018
Merged
5 tasks
@yairans yairans merged commit d6996ce into master Jul 2, 2018
@yairans yairans deleted the FEC-8368 branch July 2, 2018 10:51
yairans added a commit to kaltura/kaltura-player-js that referenced this pull request Jul 2, 2018
@yairans
chore: fix destroy test (#141)
9593689 
revert removing destroy from test #134
as it fixed by kaltura/playkit-js-ui#252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@odedhutzler odedhutzler odedhutzler approved these changes

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yairans @OrenMe @odedhutzler