feat(FEC-8390, FEC-8246): support 608/708 captions #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
yairans
changed the title
5 tasks
dan-ziv
approved these changes
Jul 13, 2018
OrenMe
requested changes
Jul 15, 2018
| @@ -234,7 +234,7 @@ class LanguageControl extends BaseComponent { | |||
| const audioOptions = props.audioTracks | |||
| .filter(t => t.label || t.language) | |||
| .map(t => ({label: t.label || t.language, active: t.active, value: t})); | |||
| const textOptions = props.textTracks.filter(t => t.kind === 'subtitles').map(t => ({ | |||
There was a problem hiding this comment.
Why remove the filter? if anything then make it tighter - subtitles or captions.
There was a problem hiding this comment.
we already filter the text tracks in the adapters.
OrenMe
approved these changes
Jul 15, 2018
OrenMe
approved these changes
Jul 17, 2018
yairans
added a commit
to kaltura/playkit-js-hls
that referenced
this pull request
Jul 17, 2018
parse 608/708 tracks by the video element `textTrack` api depends on kaltura/playkit-js#265 kaltura/playkit-js-ui#254
borhandarabi
pushed a commit
to TasvirChi/playchi-js-hls
that referenced
this pull request
May 14, 2024
parse 608/708 tracks by the video element `textTrack` api depends on kaltura/playkit-js#265 kaltura/playkit-js-ui#254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
hoverstate (need to support upper captions) with 2 ways:CheckLists