Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8421, FEC-8422): Ads UI issues #255

Merged
merged 1 commit into from
Jul 24, 2018
Merged

fix(FEC-8421, FEC-8422): Ads UI issues #255

merged 1 commit into from
Jul 24, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jul 24, 2018 •
edited

  • No ads UI Until the playback source is loaded
  • Ads UI while postroll is unlike while preroll and midroll

Description of the Changes

show player-gui while ad-break

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Jul 24, 2018
@yairans yairans requested review from OrenMe and dan-ziv July 24, 2018 08:31
@yairans yairans changed the title fix(FEC-8421, FEC-8422): No ads UI Until the playback source is loaded fix(FEC-8421, FEC-8422): Ads UI issues Jul 24, 2018
@yairans yairans requested a review from odedhutzler July 24, 2018 08:40
@yairans yairans merged commit 66ddc4e into master Jul 24, 2018
@yairans yairans deleted the FEC-8421 branch July 24, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

@odedhutzler odedhutzler Awaiting requested review from odedhutzler

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @dan-ziv