fix(FEC-8448): after 'learn more' is clicked, fullscreen button is not responding #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he full screen mode
yairans
suggested changes
Aug 6, 2018
| @@ -42,6 +43,7 @@ class FullscreenControl extends BaseComponent { | |||
| */ | |||
| constructor(obj: Object) { | |||
| super({name: 'Fullscreen', player: obj.player}); | |||
| this._prevFullscreenState = false; | |||
There was a problem hiding this comment.
better to take it from the state
this._prevFullscreenState = obj.fullscreen
There was a problem hiding this comment.
no
should be in componentWillUpdate
dan-ziv
suggested changes
Aug 6, 2018
There was a problem hiding this comment.
@odedhutzler
No need to save local full screen state since its manage in the store.
add the componentWillUpdate() lifecycle hook and just check if nextProps.fullscreen is different from the the current return value of _isFullscreen.
In that case just call fullscreenEnterHandler
calling change handler in the component will mount function.
dan-ziv
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
when you click on 'learn more' in IMA (when on full screen) it resize to the regular size. because IMA is an iframe, we cannot listen to fullscreen change event in it's document.
on each render of the full screen component, I am checking if it is different from the previous state , and renders accordingly.
CheckLists