Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8269): pre-playback overlay is displayed when loop #265

Merged
merged 1 commit into from
Aug 6, 2018
Merged

fix(FEC-8269): pre-playback overlay is displayed when loop #265

merged 1 commit into from
Aug 6, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Aug 6, 2018 •
edited

Description of the Changes

always update IsEnded to false on PLAY

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Aug 6, 2018
@yairans yairans merged commit a29ebaa into master Aug 6, 2018
@yairans yairans deleted the FEC-8269 branch August 6, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

@odedhutzler odedhutzler Awaiting requested review from odedhutzler

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe