Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8503): seekbar virtual position is incorrect when positioned in a container with CSS transform #268

Merged
merged 3 commits into from
Aug 27, 2018
Merged

fix(FEC-8503): seekbar virtual position is incorrect when positioned in a container with CSS transform #268

merged 3 commits into from
Aug 27, 2018

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Aug 23, 2018 •
edited

Description of the Changes

added the transformX to the offset calculation

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Aug 23, 2018
@OrenMe
Copy link
Contributor

OrenMe commented Aug 27, 2018

@odedhutzler build is failing due to Flow - AFAICS you can omit the null from getComputedStyle

@odedhutzler odedhutzler merged commit 449d564 into master Aug 27, 2018
@odedhutzler odedhutzler deleted the FEC-8503 branch August 27, 2018 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@odedhutzler odedhutzler

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@odedhutzler @OrenMe