feat(FEC-7681): add i18n support #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-ziv
previously requested changes
Sep 5, 2018
| @@ -34,6 +35,8 @@ class UIManager { | |||
| store: any; | |||
| container: ?HTMLElement; | |||
| root: React$Component<any, any, any>; | |||
| _translations: {[langKey: string]: Object} = {en: en_translations}; | |||
There was a problem hiding this comment.
Create TranslationManager which will return u this object
| * @private | ||
| * @returns {void} | ||
| */ | ||
| _setLocaleTranslations(config: UIOptionsObject): void { |
| @@ -141,7 +164,7 @@ class UIManager { | |||
| // i18n, redux and initial player-to-store connector setup | |||
| const template = ( | |||
| <Provider store={this.store}> | |||
| <IntlProvider definition={definition}> | |||
| <IntlProvider definition={this._translations[this._locale]}> | |||
There was a problem hiding this comment.
translationManager.getTranslation()
OrenMe
dismissed
dan-ziv’s stale review
translationManager will be a HoC in future release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
adding full mapping and some re-org of components.
The translations can be added via the config object, currently only supporting setting the locale language on init of ui manager.
The config accepts:
the base config is english and any additional config dictionary with missing keys will inherit the english ones.
CheckLists