Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8462): Thumbnail scrubber preview is overridden when multiple players are loaded simultaneously #275

Merged
merged 1 commit into from
Sep 26, 2018
Merged

fix(FEC-8462): Thumbnail scrubber preview is overridden when multiple players are loaded simultaneously #275

merged 1 commit into from
Sep 26, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Sep 26, 2018 •
edited

Description of the Changes

DON'T MESS THE GLOBAL STATE OBJECT!!!

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Sep 26, 2018
@dan-ziv dan-ziv requested a review from OrenMe September 26, 2018 13:27
@dan-ziv dan-ziv merged commit 987a280 into master Sep 26, 2018
@dan-ziv dan-ziv deleted the FEC-8462 branch September 26, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @OrenMe