feat(FEC-8277): Add picture-in-picture support #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
requested changes
Oct 25, 2018
+ player API + new icon
dan-ziv
suggested changes
Oct 31, 2018
| * @class PictureInPicture | ||
| * @extends {BaseComponent} | ||
| */ | ||
| class PictureInPicture extends BaseComponent { |
There was a problem hiding this comment.
Don't create the component at all if isPictureInPictureSupported() returns false.
There was a problem hiding this comment.
@dan-ziv we will use this component rendering like this.
virtual DOM knows to render or not by receiving undefined.
webkitpresentationmode is updated after 'loadedmetadata' event is raised. Checking this after loadedmetadata event is updated.
OrenMe
approved these changes
Oct 31, 2018
|
@odedhutzler need to listen to enter exit chrome events and change state accordingly |
dan-ziv
suggested changes
Nov 4, 2018
| * @class PictureInPicture | ||
| * @extends {BaseComponent} | ||
| */ | ||
| class PictureInPicture extends BaseComponent { |
dan-ziv
reviewed
Nov 4, 2018
| @@ -59,6 +60,7 @@ export function playbackUI(props: any): React$Element<any> { | |||
| <LanguageControl player={props.player} /> | |||
| <SettingsControl player={props.player} /> | |||
| <CastControl player={props.player} /> | |||
| <PictureInPicture player={props.player} /> | |||
There was a problem hiding this comment.
dont create the component if PIP isn't supported
dan-ziv
approved these changes
Nov 4, 2018
| @@ -0,0 +1,4 @@ | |||
| .picture-in-picture{ | |||
There was a problem hiding this comment.
place this inside .player class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
added a picture in picture support for chrome (from version 70) + safari.
still pending design. the icon place + design is still pending Hillel design
CheckLists