Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8644): the playlist jumps to the last item - safari and FF #291

Merged
merged 2 commits into from
Nov 7, 2018
Merged

fix(FEC-8644): the playlist jumps to the last item - safari and FF #291

merged 2 commits into from
Nov 7, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Nov 7, 2018 •
edited

Description of the Changes

issue: in some browsers the currentTime is not updated immediately in change media
solution: set currentTime: 0 on CHANGE_SOURCE_STARTED

reverted here #294, but eventually not reverted here #300.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Nov 7, 2018
@yairans yairans requested review from dan-ziv and a team and removed request for a team and dan-ziv November 7, 2018 09:04
@OrenMe OrenMe changed the title fix(FEC-8644): The playlist jumps to the last item - safari and FF fix(FEC-8644): אhe playlist jumps to the last item - safari and FF Nov 7, 2018
@OrenMe OrenMe changed the title fix(FEC-8644): אhe playlist jumps to the last item - safari and FF fix(FEC-8644): the playlist jumps to the last item - safari and FF Nov 7, 2018
@yairans yairans merged commit b7a3bdf into master Nov 7, 2018
@yairans yairans deleted the FEC-8644 branch November 7, 2018 13:48
@yairans yairans mentioned this pull request Nov 8, 2018
Merged
5 tasks
yairans added a commit that referenced this pull request Nov 8, 2018
@yairans
fix(): countdown skips the postroll (#294)
89e8d9a 
* listen to `PLAYBACK_ENDED` instead of `ENDED`
* revert #291 since it not needed any more
borhandarabi pushed a commit to TasvirChi/playchi-js-ui that referenced this pull request May 15, 2024
fix(): countdown skips the postroll (#294)
44bde31 
* listen to `PLAYBACK_ENDED` instead of `ENDED`
* revert kaltura/playkit-js-ui#291 since it not needed any more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yairans @OrenMe @dan-ziv