Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8669): countdown skips the postroll #294

Merged
merged 3 commits into from
Nov 8, 2018
Merged

fix(FEC-8669): countdown skips the postroll #294

merged 3 commits into from
Nov 8, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Nov 8, 2018 •
edited

Description of the Changes

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Nov 8, 2018
@yairans yairans requested a review from a team November 8, 2018 11:03
@yairans yairans changed the title fix(): countdown skips the postroll fix(FEC-8669): countdown skips the postroll Nov 8, 2018
@yairans yairans merged commit 89e8d9a into master Nov 8, 2018
@yairans yairans deleted the postroll branch November 8, 2018 15:37
This was referenced Nov 13, 2018
Merged
Merged
yairans added a commit that referenced this pull request Nov 14, 2018
@yairans
fix(FEC-8686): the playlist jumps to the last item (in case setting t…
04c74dd 
…imeToShow) (#300)

**issue:** in some browsers the `currentTime` is not updated immediately in change media
**solution:** set `currentTime: 0` on `CHANGE_SOURCE_STARTED`

despite of #294, still need this fix for `timeToShow` settings which plays next before `PLAYBACK_ENDED` event.
borhandarabi pushed a commit to TasvirChi/playchi-js-ui that referenced this pull request May 15, 2024
fix(FEC-8686): the playlist jumps to the last item (in case setting t…
e4c784c 
…imeToShow) (#300)

**issue:** in some browsers the `currentTime` is not updated immediately in change media
**solution:** set `currentTime: 0` on `CHANGE_SOURCE_STARTED`

despite of kaltura/playkit-js-ui#294, still need this fix for `timeToShow` settings which plays next before `PLAYBACK_ENDED` event.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @dan-ziv