Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8671): sometimes the playlist skip to the next item immediately, with no countdown - safari #295

Merged
merged 2 commits into from
Nov 11, 2018
Merged

fix(FEC-8671): sometimes the playlist skip to the next item immediately, with no countdown - safari #295

merged 2 commits into from
Nov 11, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Nov 8, 2018 •
edited

Description of the Changes

issue: when seeking currentTime could be updated before SEEKED event (before lastSeekPoint updated)
solution: do not update the countdown component while seeking

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Nov 8, 2018
@yairans yairans requested a review from a team November 8, 2018 12:48
@yairans yairans changed the title fix(FEC-8671): Sometimes the playlist skip to the next item immediate… fix(FEC-8671): sometimes the playlist skip to the next item immediately, before the countdown finished - safari Nov 8, 2018
@yairans yairans changed the title fix(FEC-8671): sometimes the playlist skip to the next item immediately, before the countdown finished - safari fix(FEC-8671): sometimes the playlist skip to the next item immediately, with no countdown - safari Nov 8, 2018
@yairans
Merge branch 'master' of https://github.com/kaltura/playkit-js-ui into …
0e0ff3b 
…FEC-8671

# Conflicts:
#	src/components/playlist-countdown/playlist-countdown.js
@yairans yairans merged commit b12c0fa into master Nov 11, 2018
@yairans yairans deleted the FEC-8671 branch November 11, 2018 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

@odedhutzler odedhutzler odedhutzler approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yairans @dan-ziv @odedhutzler