Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not show countdown when it is longer than the playback duration #296

Merged
merged 1 commit into from
Nov 8, 2018
Merged

fix: do not show countdown when it is longer than the playback duration #296

merged 1 commit into from
Nov 8, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Nov 8, 2018 •
edited

Description of the Changes

prevent countdown for short playback

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Nov 8, 2018
@yairans yairans requested a review from a team November 8, 2018 13:08
@yairans yairans merged commit 7271bd2 into master Nov 8, 2018
@yairans yairans deleted the long-duration branch November 8, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe