Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8650): video continues in PiP window when full screen opened #297

Merged
merged 1 commit into from
Nov 11, 2018
Merged

fix(FEC-8650): video continues in PiP window when full screen opened #297

merged 1 commit into from
Nov 11, 2018

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Nov 11, 2018 •
edited

Description of the Changes

When entering full screen when PIP mode, the video element stays in PIP (on chrome).
Added a check (isInPictureInPicture()) before entering fullscreen in the UI.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Nov 11, 2018
@odedhutzler odedhutzler merged commit 695f672 into master Nov 11, 2018
@odedhutzler odedhutzler deleted the FEC-8650 branch November 11, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@odedhutzler odedhutzler

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@odedhutzler @OrenMe