Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8683): playlist by config, no ui for the second entry and onwards #298

Merged
merged 2 commits into from
Nov 13, 2018
Merged

fix(FEC-8683): playlist by config, no ui for the second entry and onwards #298

merged 2 commits into from
Nov 13, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Nov 12, 2018 •
edited

Description of the Changes

  • NULL protection
  • Do not render next/prev/countdown when relevant data is missing

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Nov 12, 2018
@yairans yairans requested a review from a team November 12, 2018 15:24
@yairans yairans changed the title fix(FEC-8683): playlist by config no UI for the second entry and onwards fix(FEC-8683): playlist by config no ui for the second entry and onwards Nov 12, 2018
@yairans yairans changed the title fix(FEC-8683): playlist by config no ui for the second entry and onwards fix(FEC-8683): playlist by config, no ui for the second entry and onwards Nov 13, 2018
@yairans yairans merged commit 3745803 into master Nov 13, 2018
@yairans yairans deleted the FEC-8683 branch November 13, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe