Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8686): the playlist jumps to the last item (in case setting timeToShow) #302

Merged
merged 3 commits into from
Nov 14, 2018
Merged

fix(FEC-8686): the playlist jumps to the last item (in case setting timeToShow) #302

merged 3 commits into from
Nov 14, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Nov 14, 2018 •
edited

Description of the Changes

update currentTime: 0 on PLAYER_RESET because CHANGE_SOURCE_STARTED is sometimes too late

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Nov 14, 2018
@yairans yairans requested a review from dan-ziv November 14, 2018 10:50
@yairans yairans merged commit 94f880f into master Nov 14, 2018
@yairans yairans deleted the FEC-8686 branch November 14, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @dan-ziv