Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disabled playlist button is black #303

Merged
merged 2 commits into from
Nov 20, 2018
Merged

fix: disabled playlist button is black #303

merged 2 commits into from
Nov 20, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Nov 20, 2018 •
edited

image

Description of the Changes

use opacity for disabled button instead of dedicated icon with gray color

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Nov 20, 2018
@yairans yairans requested a review from a team November 20, 2018 10:35
@yairans yairans merged commit d1105a3 into master Nov 20, 2018
@yairans yairans deleted the disabled-playlist-button branch November 20, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @dan-ziv