Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cast ui #304

Merged
merged 1 commit into from
Nov 20, 2018
Merged

fix: cast ui #304

merged 1 commit into from
Nov 20, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Nov 20, 2018

Description of the Changes

Fix cast sender ui after update sender with new player events and components.
kaltura/playkit-js-cast-sender#7

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv requested a review from a team November 20, 2018 10:45
@dan-ziv dan-ziv merged commit fc82543 into master Nov 20, 2018
@dan-ziv dan-ziv deleted the fix-cast-ui branch November 20, 2018 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @yairans