Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8682): end screen #306

Merged
merged 9 commits into from
Dec 9, 2018
Merged

feat(FEC-8682): end screen #306

merged 9 commits into from
Dec 9, 2018

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Nov 25, 2018 •
edited

Description of the Changes

implement the single media end screen:

  • remove the poster
  • display the top/bottom bar
  • consider idle state
  • simplify the prePlayback state and PrePlaybackPlayOverlay component
  • remove CastAfterPlay component

end screen

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans
feat(FEC-8682): end screen
14c5f9a
@yairans
Merge branch 'master' of https://github.com/kaltura/playkit-js-ui into …
8ac1c68 
…FEC-8682

# Conflicts:
#	src/components/cast-on-tv/cast-before-play.js
#	src/components/play-pause/play-pause.js
#	src/components/pre-playback-play-overlay/pre-playback-play-overlay.js
@yairans
feat(FEC-8682): end screen. cont.
41f9ea3
@yairans
Merge branch 'master' of https://github.com/kaltura/playkit-js-ui into …
0999d8a 
…FEC-8682
@yairans yairans requested a review from a team November 25, 2018 11:19
@yairans yairans self-assigned this Nov 25, 2018
dan-ziv
dan-ziv suggested changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@dan-ziv dan-ziv left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.
Did u checked cast ui has no regressions from this change?

@yairans yairans mentioned this pull request Nov 27, 2018
Merged
5 tasks
@yairans
remove CastAfterPlay component
1ebb4a1
@yairans
Merge branch 'master' of https://github.com/kaltura/playkit-js-ui into …
bdac928 
…FEC-8682

# Conflicts:
#	src/components/pre-playback-play-overlay/pre-playback-play-overlay.js
@yairans yairans merged commit ae87bc9 into master Dec 9, 2018
yairans added a commit to kaltura/playkit-js-cast-sender that referenced this pull request Dec 9, 2018
@yairans
feat(FEC-8682): end screen (#8)
9d1c007 
remove `CastAfterPlay` component because the chromecast button is exposed as part of the bottom bar also on ended. 
depended on kaltura/playkit-js-ui#306
@yairans yairans deleted the FEC-8682 branch December 9, 2018 13:25
@yairans yairans mentioned this pull request Jan 30, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @dan-ziv