Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-8671): add CVAA menu labels/ids to enable external CSS to customize it #308

Merged
merged 4 commits into from
Dec 2, 2018

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Nov 27, 2018

Description of the Changes

add classes to the cvaa menu items
background: initial, so it will be in the global style object. background initial will set the background to the default value of the browser.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

add classes to the cvaa menu items
background: initial, so it will be in the global style object. background initial will set the background to the default value of the browser.
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a guide for the CVAA override

@odedhutzler odedhutzler merged commit cd1f115 into master Dec 2, 2018
@odedhutzler odedhutzler deleted the FEC-8571 branch December 2, 2018 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants